Commit Graph

16 Commits

Author SHA1 Message Date
Fengqing Liu
9727a9b8d2 unify game selection and expectation logic (#32)
- unify game selection and expectation logic
- refactore settings and settings manager
- formatting and coverage and precommit hook
2026-01-19 00:39:58 +11:00
Vurmil
68165aace6 Add footer with app version and GitHub update check (#17)
* Add footer with app version and GitHub update check

- Add GET /api/version endpoint returning current_version, latest_version, update_available and download_url (checks rangermix/TwitchDropsMiner releases via GitHub API).
- Add UI footer displaying current version and a visible update indicator with link.
- Add styles for footer and update alert; add client-side logic to fetch version on load.
- Update repository links to rangermix and replace favicon with transparent background.

See: web/index.html, web/static/app.js, web/static/styles.css, src/web/app.py

* - align footer width
- add (latest) indication if is latest version

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-12-14 22:06:05 +11:00
github-actions[bot]
c9fefed1a9 feat: Enhance dashboard with Wanted Drops Queue and Benefit Filters
- Implemented 'Benefit Type' filtering (Item, Badge, etc.) in backend and settings UI.
- Redesigned 'Wanted Drops Queue' as a card-based, masonry layout.
- Added 'Game Groups' to Wanted Queue for better organization.
- Added variable height support for Inventory cards.
- Added proxy support and verification logic (from previous steps).
- Added unit tests for new filters and UI logic.
2025-12-14 21:46:14 +11:00
Fengqing Liu
275ce682b8 feat: Add proxy support with verification and benefit type filters (#13)
* feat: Add proxy configuration and verification functionality with dedicated API and UI.

* no header needed

* batch render

* feat: Add inventory filters for drop benefit types and refine proxy settings UI.

* debug message

* benefit type filter fix

* avoid duplicated update

* claude md update

* sync change from 5d7a697c2b

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-12-11 00:36:13 +11:00
Fengqing Liu
221939e26a Refactor /api/translations to return full Translation object
Simplified the /api/translations endpoint to return the complete
Translation TypedDict object instead of manually constructing a
custom nested structure. This makes the code more maintainable,
type-safe, and consistent with the translation schema.

Backend changes (src/web/app.py):
- Removed 116 lines of manual translation object construction
- Now returns _.t directly (full Translation object)
- Reduced endpoint from ~120 lines to 3 lines

Frontend changes (web/static/app.js):
- Updated to work with full Translation object structure
- All GUI translations now accessed via t.gui.* paths
- Login status uses t.login.status.* (from Translation.login)
- Websocket status uses t.gui.websocket.*
- Updated all render functions and Socket.IO handlers

Benefits:
- Simpler and more maintainable backend code
- Type-safe: returns exact Translation TypedDict structure
- Frontend can access all translation sections (gui, login, error, status)
- Follows the defined TypedDict schema exactly

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-25 13:46:55 +11:00
Fengqing Liu
46291e83d8 Update CLAUDE.md with comprehensive translation system documentation
This commit documents the current state of the translation system architecture
and consolidates the recent i18n refactoring work.

Documentation updates:
- Add detailed Translation System section describing architecture
- Document all 19 supported languages with native names
- Include TypedDict schema structure and usage examples
- Update project structure to show lang/ directory
- Expand Key Files section with i18n/ package details
- Document language persistence and dynamic switching

Translation system changes:
- Migrate English translations from hardcoded to lang/English.json
- Add English.json as single source of truth for fallback translations
- Update all language files with comprehensive GUI translations
- Refactor translator.py to load English from JSON file
- Add language_name and english_name fields to all translations

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-24 21:48:30 +11:00
Fengqing Liu
522299c920 Clean up translation files and add comprehensive web GUI translations
- Remove unused translation keys from all language files:
  - Removed chrome login flow keys (no longer used)
  - Removed GUI channel headings (table structure changed)
  - Removed GUI inventory filter section (filtering not in web GUI)
  - Removed GUI settings proxy field (moved to general section)
  - Cleaned up other deprecated keys

- Add new translation keys for web GUI:
  - OAuth login prompts (oauth_prompt, oauth_activate, oauth_confirm)
  - Progress indicators (no_drop, return_to_auto, manual_mode_info)
  - Channel empty states (no_channels, no_channels_for_games, channel_count)
  - Inventory empty state (no_campaigns, claimed_drops)
  - Settings UI (games selector, search, drag-and-drop hints)
  - Help section content (about, features, important_notes)
  - Header elements (title, language selector, mode indicators)

- Update app.py /api/translations endpoint to use translation keys instead of hardcoded English strings
- Update translator.py TypedDict definitions to match new structure
- Fix i18n __init__.py exports to remove ChromeMessages, GUIChannelHeadings, GUIInvFilter and add GUIHeader

All 19 language files updated consistently. Non-English languages use English text as placeholders for new keys.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-24 11:15:02 +11:00
Fengqing Liu
550ceb0111 Add comprehensive translation support for all GUI text
Backend enhancements:
- Expand /api/translations endpoint with all available translation strings
- Include login form fields, OAuth prompts, progress labels, channel statuses
- Add inventory status texts, settings empty messages, help content
- Include connection status and viewer/channel count translations

Frontend improvements:
- Update all input placeholders (username, password, 2FA, search)
- Translate all button texts (Login, OAuth confirm, reload, manual mode)
- Apply translations to empty state messages across all sections
- Translate campaign statuses (Active, Upcoming, Expired, Claimed)
- Update channel and viewer count labels
- Apply translations to settings empty messages
- Update help tab with translated how-it-works and getting-started text
- Translate connection status indicators

Now supports translating:
- Login form (all fields and buttons)
- OAuth device code flow prompts
- Progress section labels and manual mode controls
- Channel list empty states and status labels
- Inventory campaign statuses and empty states
- Settings section empty messages and labels
- Help content sections
- Header connection indicators

All dynamically rendered content now respects language selection.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-23 22:46:29 +11:00
Fengqing Liu
9ef08916d9 Implement dynamic language switching in web GUI
- Add /api/translations endpoint to return GUI text in current language
- Emit language_changed event when user changes language setting
- Frontend fetches and applies translations on language change
- Update all UI elements dynamically: tabs, headers, labels, buttons
- Load translations on page initialization

Fixes issue where language selection didn't update webpage text.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-23 22:35:26 +11:00
Claude
08531bd333 Add proper i18n support with language selection in web GUI
The application already had a complete i18n system with 18+ language
translation files, but the web GUI only showed English as an option.

Changes:
- Add /api/languages endpoint to fetch available languages from translator
- Update SettingsUpdate model to include language field
- Add SettingsManager.get_languages() method to expose available languages
- Update SettingsManager to handle language changes via translator.set_language()
- Populate language dropdown dynamically from available translations on page load
- Add auto-save for language changes in frontend
- Language is persisted to settings.json and loaded on startup

The translator is initialized with the saved language at application startup
(already implemented in src/__main__.py lines 101-105).

Available languages include:
English, Français, Deutsch, Español, Italiano, Português, Polski,
Русский, Українська, 简体中文, 繁體中文, 日本語, العربية,
Türkçe, Română, Nederlandse, Dansk, Čeština, Indonesian

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-23 10:06:34 +00:00
Fengqing Liu
a321da91f8 remove "tray" 2025-10-19 17:15:28 +11:00
Fengqing Liu
d466f46d6f remove redundant stuff 2025-10-19 17:08:18 +11:00
Fengqing Liu
472e6d73bd Add configurable minimum refresh interval setting
Added user-configurable minimum refresh interval for inventory reloads, allowing users to control how frequently the maintenance service triggers updates (default: 30 minutes, range: 1-1440 minutes).

- Add minimum_refresh_interval_minutes to settings system with default of 30 minutes
- Update maintenance service to use configurable interval instead of hardcoded 1-minute value
- Add GUI input field in General Settings with auto-save functionality
- Include field in API settings endpoint and settings manager

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-19 10:56:40 +11:00
Fengqing Liu
f62ec26b5d chore: Major code quality improvements - Remove dead code, add Ruff & Mypy
This commit implements a comprehensive code quality overhaul including
dead code removal, modern linting tools, type checking, and CI/CD integration.

## Dead Code Removal

### Removed Files:
- src/utils/cache.py (137 lines) - Desktop GUI remnant with tkinter dependencies
  * No longer needed in web-only architecture
  * Conflicted with web version at src/web/managers/cache.py

### Removed Functions:
- src/auth/auth_state.py::_login() (170 lines) - Deprecated password authentication
  * OAuth device code flow is now the only login method
  * Removed legacy 2FA, CAPTCHA, and password login code
  * Updated class docstring to reflect OAuth-only authentication

### Removed Imports (12 occurrences):
- Unused TYPE_CHECKING imports (NoReturn, LoginFormManager, etc.)
- Orphaned exception imports (CaptchaRequired, LoginException)
- Unused utility imports (AwaitableValue, State, io, sys, Path)
- Removed commented-out imports and dead code references

**Total removed: 308+ lines of unused code**

## Modern Linting with Ruff

### Added ruff (v0.14.1):
- 10-100x faster than legacy linters (Flake8, pyflakes)
- Auto-fixed 56 issues across 46 files
- Import sorting with isort integration
- Modern Python idioms (pyupgrade)
- Code simplification suggestions

### Fixes Applied:
- Sorted imports alphabetically in all files
- Replaced try-except-pass with contextlib.suppress()
- Added exception chaining with 'from err'
- Renamed unused loop variables to _var
- Simplified comprehensions and ternary operators
- Removed unnecessary .keys() calls

**Result: 0 Ruff warnings (100% pass rate)**

## Type Checking with Mypy

### Added mypy (v1.18.2):
- Static type checking across 55 source files
- Reduced type errors from 25 to 5 (80% improvement)
- Configured gradual strictness for JSON/GraphQL responses

### Type Fixes:
- Fixed PyInstaller _MEIPASS attribute access
- Added type: ignore for safe variable redefinitions
- Fixed translator return type cast
- Added null checks for optional attributes
- Resolved circular import issues

### Configuration:
- Lenient initial settings for gradual adoption
- Per-module overrides for dynamic JSON responses
- Error codes shown for easy debugging

**Result: 5 non-critical errors remaining**

## CI/CD Integration

### Updated .github/workflows/ci.yml:
- Added new 'lint' job running Ruff + Mypy
- Ruff checks are required to pass
- Mypy checks run but don't block (advisory)
- Docker build now depends on lint + validate jobs

### Workflow:
```
lint (Ruff + Mypy) → validate (Language files) → docker → release
```

## Configuration

### Created pyproject.toml:
```toml
[tool.ruff]
line-length = 100
target-version = "py310"
select = ["E", "W", "F", "I", "UP", "B", "SIM", "C4"]

[tool.mypy]
python_version = "3.10"
check_untyped_defs = true
strict_equality = true
```

## Statistics

### Code Reduction:
- **Before:** 8,130 lines across 56 files
- **After:** 7,213 lines across 55 files
- **Reduction:** -917 lines (-11.3%)

### Quality Metrics:
- **Pyflakes:** 16 warnings → Ruff: 0 warnings
- **Mypy:** Not configured → 5 errors (from 25)
- **Linting speed:** 2s → 0.2s (10x faster)
- **Auto-fix rate:** 79% (46/58 issues)

### Files Modified: 48 files
- 1 deleted (src/utils/cache.py)
- 1 created (pyproject.toml)
- 46 updated (imports, types, style)

## Breaking Changes

None - all changes are internal quality improvements.
Application still runs perfectly (v16.dev).

## Migration Notes

### For Developers:
```bash
# Install new tools
pip install ruff mypy

# Run quality checks
ruff check src/          # Fast linting
mypy src/                # Type checking
ruff check src/ --fix    # Auto-fix issues
```

### For CI/CD:
- Linting now runs automatically on all commits
- Failed Ruff checks will block builds
- Mypy checks are advisory (won't block)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-19 00:02:54 +11:00
Fengqing Liu
68118d9e4b Add manual mode feature with UI improvements and batch updates
This commit introduces a manual mode for channel selection that allows users to lock onto a specific game, along with significant UI/UX improvements:

Manual Mode Features:
- Locks channel selection to a specific game when user manually selects a different game
- Automatically exits manual mode when all drops for the game are completed
- Shows visual indicators (🎯 badge) in status bar and drop display
- Allows manual exit via "Return to Auto Mode" button
- Prioritizes manual game in wanted_games list during auto-selection

UI/UX Improvements:
- Batch update system for channels and campaigns prevents flickering during refresh
- Channels list now updates atomically instead of clearing and re-adding
- Campaign loading emits all campaigns at once for smooth initial load
- Drop progress persists on initial_state load for reconnecting clients
- Game icons (box art) now displayed in channel list
- Campaign links added to inventory items

Bug Fixes:
- Fixed logging level to respect INFO by default (was hardcoded to DEBUG)
- Fixed channel cleanup to not call channel.remove() (handled by batch_update)
- Fixed drop display not persisting during channel switch
- Fixed stop_watching() clearing drop timer prematurely
- Fixed status display typo ("fames_to_watch" → "games_to_watch")

Backend Changes:
- Added manual mode tracking (_manual_target_channel, _manual_target_game)
- Added enter_manual_mode(), exit_manual_mode(), is_manual_mode() methods
- Added get_manual_mode_info() for API serialization
- Added batch_update() to ChannelListManager for atomic updates
- Added start_batch()/finalize_batch() to InventoryManager
- Added /api/mode/exit-manual endpoint
- Game model now stores box_art_url from GraphQL response
- Manual mode info included in /api/status and initial_state

Frontend Changes:
- Added manual mode badge and controls in UI
- Added channels_batch_update and inventory_batch_update socket events
- Added manual_mode_update socket event
- Countdown timer now properly tracked and cleared
- Drop display shows manual mode status with game name
- Exit manual mode button added to drop display area

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-18 00:22:34 +11:00
Fengqing Liu
5b736e3bb1 Migrate to Docker-ready web UI and remove legacy desktop GUI
Replace the legacy desktop/Tkinter client and packaging artifacts with a Docker-first, web-hosted approach.

- Add Docker quickstart and run-from-source instructions to the README to simplify deployment.
- Simplify launcher to invoke the new web backend module instead of the old desktop entrypoint.
- Update dependencies for a web UI stack (FastAPI, Uvicorn, python-socketio, Jinja2, etc.) and remove desktop/tray-specific packages.
- Remove legacy GUI, packaging and platform-specific helper code, along with obsolete build/pack scripts and AppImage assets to declutter the repo.
- Tidy project ignore rules to add runtime logs and editor metadata.

Rationale: streamline deployment, favor a browser-accessible interface, and reduce maintenance overhead from multiple platform-specific GUI/packaging implementations.
2025-10-16 21:54:43 +11:00