GitHub/noVNC
1
0
Fork 0
mirror of https://github.com/novnc/noVNC.git synced 2026-05-30 17:09:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1318 from chrisjdev/emptyPassword

Browse Source 
Allow connecting with empty string credentials
This commit is contained in:
Samuel Mannehed
2019-12-05 12:15:43 +01:00
committed by GitHub
parent 80b078c469 01d4514dee
commit b39caa7469
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/rfb.js
View File

@@ -940,9 +940,9 @@ export default class RFB extends EventTargetMixin {
// authentication
_negotiate_xvp_auth() {
if (!this._rfb_credentials.username ||
!this._rfb_credentials.password ||
!this._rfb_credentials.target) {
if (this._rfb_credentials.username === undefined ||
this._rfb_credentials.password === undefined ||
this._rfb_credentials.target === undefined) {
this.dispatchEvent(new CustomEvent(
"credentialsrequired",
{ detail: { types: ["username", "password", "target"] } }));
@@ -961,7 +961,7 @@ export default class RFB extends EventTargetMixin {
_negotiate_std_vnc_auth() {
if (this._sock.rQwait("auth challenge", 16)) { return false; }
if (!this._rfb_credentials.password) {
if (this._rfb_credentials.password === undefined) {
this.dispatchEvent(new CustomEvent(
"credentialsrequired",
{ detail: { types: ["password"] } }));