GitHub/noVNC
1
0
Fork 0
mirror of https://github.com/novnc/noVNC.git synced 2026-05-28 16:09:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix global error handler

Browse Source 
It stopped working when we switched to textContent as it relies
on being able to add new HTML elements. Do things properly by
adding new elements via createElement().
This commit is contained in:
Pierre Ossman
2017-01-18 15:59:31 +01:00
parent 1ec1c512af
commit 413ea87741
1 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
app/ui.js
View File

@@ -28,27 +28,35 @@ var UI;
// Fallback for all uncought errors
window.addEventListener('error', function(event) {
try {
var msg = "";
var msg, div, text;
msg += "<div>";
msg += event.message;
msg += "</div>";
msg = document.getElementById('noVNC_fallback_errormsg');
msg += " <div class=\"noVNC_location\">";
msg += event.filename;
msg += ":" + event.lineno + ":" + event.colno;
msg += "</div>";
// Only show the initial error
if (msg.hasChildNodes()) {
return false;
}
div = document.createElement("div");
div.appendChild(document.createTextNode(event.message));
msg.appendChild(div);
div = document.createElement("div");
div.className = 'noVNC_location';
text = event.filename + ":" + event.lineno + ":" + event.colno;
div.appendChild(document.createTextNode(text));
msg.appendChild(div);
if ((event.error !== undefined) &&
(event.error.stack !== undefined)) {
msg += "<div class=\"noVNC_stack\">";
msg += event.error.stack;
msg += "</div>";
div = document.createElement("div");
div.className = 'noVNC_stack';
div.appendChild(document.createTextNode(event.error.stack));
msg.appendChild(div);
}
document.getElementById('noVNC_fallback_error')
.classList.add("noVNC_open");
document.getElementById('noVNC_fallback_errormsg').textContent = msg;
} catch (exc) {
document.write("noVNC encountered an error.");
}