builder, aruco_pose, clever: Use python3 wherever possible

aruco_pose/src/genmap.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 # Copyright (C) 2018 Copter Express Technologies
 #

builder/image-software.sh

@@ -97,21 +97,21 @@ libjpeg8 \
 tcpdump \
 ltrace \
 libpoco-dev \
-python-rosdep \
-python-rosinstall-generator \
-python-wstool \
-python-rosinstall \
+python3-rosdep \
+python3-rosinstall-generator \
+python3-wstool \
+python3-rosinstall \
 build-essential \
 libffi-dev \
 monkey \
 pigpio python-pigpio python3-pigpio \
 i2c-tools \
-espeak espeak-data python-espeak \
+espeak espeak-data python-espeak python3-espeak \
 ntpdate \
 python-dev \
 python3-dev \
 python3-venv \
-python-systemd \
+python3-systemd \
 mjpg-streamer \
 && echo_stamp "Everything was installed!" "SUCCESS" \
 || (echo_stamp "Some packages wasn't installed!" "ERROR"; exit 1)
@@ -123,10 +123,9 @@ sed -i "s/updates_available//" /usr/share/byobu/status/status
 echo_stamp "Installing pip"
 curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
 python3 get-pip.py
-python get-pip.py
+# Don't even bother installing pip for python2.7
+# python get-pip.py
 rm get-pip.py
-#my_travis_retry pip install --upgrade pip
-#my_travis_retry pip3 install --upgrade pip
 
 echo_stamp "Make sure both pip and pip3 are installed"
 pip --version

clever/package.xml

@@ -38,7 +38,7 @@
   <depend>rosbridge_server</depend>
   <depend>web_video_server</depend>
   <depend>tf2_web_republisher</depend>
-  <depend>python-lxml</depend>
+  <depend>python3-lxml</depend>
   <exec_depend>python-pymavlink</exec_depend>
   <!-- Use test_depend for packages you need only for testing: -->
   <!--   <test_depend>gtest</test_depend> -->

clever/src/selfcheck.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # coding=utf-8
 
 # Copyright (C) 2018 Copter Express Technologies

clever/src/simple_offboard.cpp

@@ -177,6 +177,8 @@ inline bool waitTransform(const string& target, const string& source,
 		ros::spinOnce();
 		r.sleep();
 	}
+	// At this point our node has been shut down
+	return false;
 }
 
 #define TIMEOUT(msg, timeout) (ros::Time::now() - msg.header.stamp > timeout)
@@ -749,6 +751,8 @@ bool land(std_srvs::Trigger::Request& req, std_srvs::Trigger::Response& res)
 		busy = false;
 		return true;
 	}
+	// We should not end up here, but if we did, our node has been shut down
+	return false;
 }
 
 int main(int argc, char **argv)