GitHub/noVNC
1
0
Fork 0
mirror of https://github.com/novnc/noVNC.git synced 2026-05-26 07:08:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken clipboard unittests

Browse Source 
We can't compare with a new CustomEvent, lets check the call arguments
instead. The field is also called "text".
This commit is contained in:
Samuel Mannehed
2026-05-22 17:59:54 +02:00
parent 816a4c7f24
commit 4bce309c3b
1 changed files with 12 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tests/test.rfb.js
View File

@@ -3485,7 +3485,7 @@ describe('Remote Frame Buffer protocol client', function () {
expectedStr expectedStr
)).to.be.true; )).to.be.true;
expect(dispatchEventSpy.calledWith( expect(dispatchEventSpy.calledWith(
new CustomEvent("clipboard", {detail: {expectedStr: expectedStr}}) new CustomEvent("clipboard", {detail: {text: expectedStr}})
)).to.be.false; )).to.be.false;
}); });
@@ -3506,9 +3506,8 @@ describe('Remote Frame Buffer protocol client', function () {
expect(client._asyncClipboard.writeClipboard.calledOnceWith( expect(client._asyncClipboard.writeClipboard.calledOnceWith(
expectedStr expectedStr
)).to.be.true; )).to.be.true;
expect(dispatchEventSpy.calledOnceWith( expect(dispatchEventSpy.args[0][0].type).to.equal("clipboard");
new CustomEvent("clipboard", {detail: {expectedStr: expectedStr}}) expect(dispatchEventSpy.args[0][0].detail.text).to.equal(expectedStr);
)).to.be.true;
}); });
}); });
@@ -3587,7 +3586,7 @@ describe('Remote Frame Buffer protocol client', function () {
expectedData expectedData
)).to.be.true; )).to.be.true;
expect(dispatchEventSpy.calledOnceWith( expect(dispatchEventSpy.calledOnceWith(
new CustomEvent("clipboard", {detail: {expectedData: expectedData}}) new CustomEvent("clipboard", {detail: {text: expectedData}})
)).to.be.false; )).to.be.false;
}); });
it('should dispatch a clipboard event following unsuccessful async write clipboard', async function () { it('should dispatch a clipboard event following unsuccessful async write clipboard', async function () {
@@ -3615,9 +3614,8 @@ describe('Remote Frame Buffer protocol client', function () {
expect(client._asyncClipboard.writeClipboard.calledOnceWith( expect(client._asyncClipboard.writeClipboard.calledOnceWith(
expectedData expectedData
)).to.be.true; )).to.be.true;
expect(dispatchEventSpy.calledOnceWith( expect(dispatchEventSpy.args[0][0].type).to.equal("clipboard");
new CustomEvent("clipboard", {detail: {expectedData: expectedData}}) expect(dispatchEventSpy.args[0][0].detail.text).to.equal(expectedData);
)).to.be.true;
}); });
describe('Handle Provide', function () { describe('Handle Provide', function () {
@@ -3646,9 +3644,8 @@ describe('Remote Frame Buffer protocol client', function () {
expect(client._asyncClipboard.writeClipboard.calledOnceWith( expect(client._asyncClipboard.writeClipboard.calledOnceWith(
expectedData expectedData
)).to.be.true; )).to.be.true;
expect(dispatchEventSpy.calledOnceWith( expect(dispatchEventSpy.args[0][0].type).to.equal("clipboard");
new CustomEvent("clipboard", {detail: {expectedData: expectedData}}) expect(dispatchEventSpy.args[0][0].detail.text).to.equal(expectedData);
)).to.be.true;
}); });
it('should update clipboard with correct escape characters from a Provide message ', async function () { it('should update clipboard with correct escape characters from a Provide message ', async function () {
@@ -3677,9 +3674,8 @@ describe('Remote Frame Buffer protocol client', function () {
expect(client._asyncClipboard.writeClipboard.calledOnceWith( expect(client._asyncClipboard.writeClipboard.calledOnceWith(
expectedData expectedData
)).to.be.true; )).to.be.true;
expect(dispatchEventSpy.calledOnceWith( expect(dispatchEventSpy.args[0][0].type).to.equal("clipboard");
new CustomEvent("clipboard", {detail: {expectedData: expectedData}}) expect(dispatchEventSpy.args[0][0].detail.text).to.equal(expectedData);
)).to.be.true;
}); });
it('should be able to handle large Provide messages', async function () { it('should be able to handle large Provide messages', async function () {
@@ -3708,9 +3704,8 @@ describe('Remote Frame Buffer protocol client', function () {
expect(client._asyncClipboard.writeClipboard.calledOnceWith( expect(client._asyncClipboard.writeClipboard.calledOnceWith(
expectedData expectedData
)).to.be.true; )).to.be.true;
expect(dispatchEventSpy.calledOnceWith( expect(dispatchEventSpy.args[0][0].type).to.equal("clipboard");
new CustomEvent("clipboard", {detail: {expectedData: expectedData}}) expect(dispatchEventSpy.args[0][0].detail.text).to.equal(expectedData);
)).to.be.true;
}); });
}); });