fix(migrate-db): preserve false-valued columns in SQLite to Postgres copy

GORM struct INSERT substitutes a column default tag for Go zero-values, so disabled rows (enable=false) silently re-enabled on the destination. Copy each batch through explicit per-column maps so every value is written verbatim. Adds a regression test.
This commit is contained in:
MHSanaei
2026-06-03 14:28:14 +02:00
parent e7c11c913a
commit 71cf22fa8d
2 changed files with 94 additions and 4 deletions

View File

@@ -62,3 +62,78 @@ func TestMigrateData_CompositeKeyTableLargerThanBatch(t *testing.T) {
t.Fatalf("client_inbounds rows = %d, want %d", got, n)
}
}
func TestMigrateData_PreservesFalseDefaultedColumns(t *testing.T) {
dsn := os.Getenv("XUI_TEST_PG_DSN")
if dsn == "" {
t.Skip("set XUI_TEST_PG_DSN to a reachable Postgres to run this test")
}
srcPath := t.TempDir() + "/x-ui.db"
src, err := gorm.Open(sqlite.Open(srcPath), &gorm.Config{Logger: logger.Discard})
if err != nil {
t.Fatalf("open sqlite: %v", err)
}
for _, m := range migrationModels() {
if err := src.AutoMigrate(m); err != nil {
t.Fatalf("automigrate %T: %v", m, err)
}
}
if err := src.Create([]*model.ClientRecord{
{Email: "on@example.com"},
{Email: "off@example.com"},
}).Error; err != nil {
t.Fatalf("seed clients: %v", err)
}
if err := src.Model(&model.ClientRecord{}).Where("email = ?", "off@example.com").
Update("enable", false).Error; err != nil {
t.Fatalf("disable client: %v", err)
}
if err := src.Create(&model.Node{Name: "n-off", Address: "1.2.3.4", Port: 1, ApiToken: "tok"}).Error; err != nil {
t.Fatalf("seed node: %v", err)
}
if err := src.Model(&model.Node{}).Where("name = ?", "n-off").
Update("enable", false).Error; err != nil {
t.Fatalf("disable node: %v", err)
}
if sqlDB, err := src.DB(); err == nil {
sqlDB.Close()
}
dst, err := gorm.Open(postgres.Open(dsn), &gorm.Config{Logger: logger.Discard})
if err != nil {
t.Fatalf("open postgres: %v", err)
}
if err := dst.Migrator().DropTable(migrationModels()...); err != nil {
t.Fatalf("drop tables: %v", err)
}
if err := MigrateData(srcPath, dsn); err != nil {
t.Fatalf("MigrateData: %v", err)
}
var off model.ClientRecord
if err := dst.Where("email = ?", "off@example.com").First(&off).Error; err != nil {
t.Fatalf("load disabled client: %v", err)
}
if off.Enable {
t.Fatalf("disabled client re-enabled after migration (enable=%v)", off.Enable)
}
var on model.ClientRecord
if err := dst.Where("email = ?", "on@example.com").First(&on).Error; err != nil {
t.Fatalf("load enabled client: %v", err)
}
if !on.Enable {
t.Fatalf("enabled client wrongly disabled after migration")
}
var node model.Node
if err := dst.Where("name = ?", "n-off").First(&node).Error; err != nil {
t.Fatalf("load node: %v", err)
}
if node.Enable {
t.Fatalf("disabled node re-enabled after migration")
}
}