From 480a9b1f0ada91f7536d294669219bb224eb9fdc Mon Sep 17 00:00:00 2001
From: Oleg Kalachev <okalachev@gmail.com>
Date: Sat, 1 May 2021 08:52:42 +0300
Subject: [PATCH] =?UTF-8?q?clover.launch:=20remove=20shell=20node=20autola?=
 =?UTF-8?q?unch=20as=20it=E2=80=99s=20not=20needed?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 clover/launch/clover.launch |  4 ----
 clover/test/basic.py        | 16 ----------------
 2 files changed, 20 deletions(-)

diff --git a/clover/launch/clover.launch b/clover/launch/clover.launch
index a3e3ba8e..5626c82a 100644
--- a/clover/launch/clover.launch
+++ b/clover/launch/clover.launch
@@ -12,7 +12,6 @@
     <arg name="led" default="true"/>
     <arg name="blocks" default="false"/>
     <arg name="rc" default="true"/>
-    <arg name="shell" default="true"/>
 
     <arg name="simulator" default="false"/> <!-- flag that we are operating on a simulated drone -->
 
@@ -91,9 +90,6 @@
         <param name="use_fake_gcs" value="false"/>
     </node>
 
-    <!-- Shell access through ROS service -->
-    <node name="shell" pkg="clover" type="shell" output="screen" if="$(arg shell)"/>
-
     <!-- Update static directory -->
     <node pkg="roswww_static" name="roswww_static" type="main.py" clear_params="true">
         <param name="default_package" value="clover"/>
diff --git a/clover/test/basic.py b/clover/test/basic.py
index fe546f7d..f9a767d8 100755
--- a/clover/test/basic.py
+++ b/clover/test/basic.py
@@ -28,19 +28,3 @@ def test_simple_offboard_services_available():
 def test_web_video_server(node):
     import urllib2
     urllib2.urlopen("http://localhost:8080").read()
-
-def test_shell(node):
-    execute = rospy.ServiceProxy('exec', srv.Execute)
-    execute.wait_for_service(5)
-
-    res = execute(cmd='echo foo')
-    assert res.code == 0
-    assert res.output == 'foo\n'
-
-    res = execute(cmd='foo')
-    assert res.code == 32512
-    assert res.output == ''
-
-    res = execute(cmd='ls foo')
-    assert res.code == 512
-    assert res.output == ''