Feature branch: IMPORTANT connection+telemetry+table fixes and improvements (#55)

* .client_connected > .new_client_connected

* Fixed 'confirmation_required' wrapper

* Logging impr

* Changed and optimized a lot checks behaviour

* Added indication of connected/disconnected copters

* update_data_signal changed signature

* Added client removing functionality

* Option for automatically remove disconnected copters from table

* Renaming copters from QT server table on the go + some improvements

* Server: Check if self.clients list is not empty when trying to pop element from it

* Probably fixes behaviour of non-immidiate data sending from server

* Added changing hostname of copter

* Updated config

* Preview of selfchecheck results on double click

* Delete doc_2019-10-16_17-57-17.bashrc

* Update table data models for selfcheck

* Server: modify set id request to message

* Update client_config default file

* Client: modify set new id function

* Client: add avahi-daemon to restart when restarting network

* Client: add new hostname to ssh motd message, do not change hostname if no network restart in config

* Client: add newline to motd message

* Optimized request behaviour

* Client: fix service file and restart order

* Client: Add SO_KEEPALIVE and TCP_NODELAY options to client socket

* Modify to last tests with ping

* Client: remove ping

* Client: select reboot option when change id and add execute command

* Server: Add SO_KEEPALIVE option to server socket

* Server: Change removing copter

* Request resending after disconnection

* Resending improval (for furthrer functionality & fixes

* Fix of client removing behaviour

* Debugging

* Revert dubug code; 'Remove' fix confirmed

* do not clear requests queue

* Update requirements.txt

* Added namespace class to fix resend

* Improvements and simplification of notifier + port to client

* Refactor of telemetry thread

* Simplify lambdas

* Compress hostname check to single regex

* Changes in telemetry

* Refactored formatting of telemetry in table. NOT DONE

* Fix

* Git checkout. REVERT later!

* Conection fix

* Compability fixes

* Update start position

* Fix for reconnection with notifier socket

* Added traceback for pyqt5

* Fixes in new telemetry display

* Added lock to Telemetry

* Fixes for table display

* Fix of doubling line of client in table

* Fix of mass-removing clients from table

* Fix for clinet double-connection+removal

* Fix lock in Telemetry

* Changed signature of response callbacks for better syntax & fixes (all tested)

* Revert "Git checkout. REVERT later!"

This reverts commit 6122352380.

* Server: fix formatters

* Client: Remove telemetry_loop, small refactor of Telemetry class

* Server: Add formatters

* Server: Very small refactor

* Server: Fix checks and formatters

* Client: Fix check_failsafe function, small code refactor

* Client: update default config file

Server/server.py

@@ -146,12 +146,13 @@ class Server(messaging.Singleton):
     # noinspection PyArgumentList
     def _client_processor(self):
         logging.info("Client processor (selector) thread started!")
+
+        messaging.NotifierSock().init(self.sel)
+
         self.server_socket.listen()
         self.server_socket.setblocking(False)
         self.sel.register(self.server_socket, selectors.EVENT_READ, data=None) #| selectors.EVENT_WRITE
 
-        messaging.NotifierSock().bind((self.ip, self.port))
-
         while self.client_processor_thread_running.is_set():
             events = self.sel.select()
             #logging.error('tick')
@@ -177,15 +178,12 @@ class Server(messaging.Singleton):
         logging.info("Got connection from: {}".format(str(addr)))
         conn.setblocking(False)
 
-        if addr[0] == self.ip and messaging.NotifierSock().addr is None:
-            client = messaging.NotifierSock()
-            logging.info("Notifier sock client")
-
-        elif not any([client_addr == addr[0] for client_addr in Client.clients.keys()]):
+        if not any([client_addr == addr[0] for client_addr in Client.clients.keys()]):
             client = Client(addr[0])
             logging.info("New client")
         else:
             client = Client.clients[addr[0]]
+            client.close(True)  # to ensure in unregistering
             logging.info("Reconnected client")
         self.sel.register(conn, selectors.EVENT_READ, data=client)
         client.connect(self.sel, conn, addr)
@@ -284,7 +282,7 @@ class Client(messaging.ConnectionManager):
 
     @staticmethod
     def get_by_id(copter_id):
-        for client in Client.clients.values():
+        for client in Client.clients.values():  # TODO filter
             if client.copter_id == copter_id:
                 return client
 
@@ -303,10 +301,12 @@ class Client(messaging.ConnectionManager):
         if self.on_connect:
             self.on_connect(self)
 
-    def _got_id(self, value):
+    def _got_id(self, _client, value):
         logging.info("Got copter id: {} for client {}".format(value, self.addr))
+        old_id = self.copter_id
         self.copter_id = value
-        if self.on_first_connect:
+
+        if old_id is None and self.on_first_connect:
             self.on_first_connect(self)
 
     def close(self, inner=False):
@@ -325,11 +325,12 @@ class Client(messaging.ConnectionManager):
     def remove(self):
         if self.connected:
             self.close()
-        if self.clients:
-            try:
-                self.clients.pop(self.addr[0])
-            except Exception as e:
-                logging.error(e)
+
+        try:
+            self.clients.pop(self.addr[0])
+        except KeyError as e:
+            logging.error(e)
+
         logging.info("Client {} successfully removed!".format(self.copter_id))
 
     @requires_connect